Support mac_os compatiblity#3
Open
comwitch wants to merge 4 commits intonv-tlabs:mainfrom
Open
Conversation
eadwu
reviewed
Mar 19, 2026
|
|
||
| #include <stdint.h> | ||
| #include <immintrin.h> | ||
| #ifdef __APPLE__ |
There was a problem hiding this comment.
defined(__ARM_FEATURE_SIMD32) || defined(__ARM_NEON) instead? I can confirm that these header files also work for compiling aarch64 on Linux.
Author
There was a problem hiding this comment.
Hi, i changed the Flag which can find arm-based architecture. #if defined(__aarch64__) || defined(__ARM_NEON)
but I don't know about aarch64 on Linux so I can't guarantee that it works on aarch64 linux. (but still works on apple silicon mac)
eadwu
reviewed
Mar 19, 2026
| if(MSVC) | ||
| # MSVC-specific flags | ||
| target_compile_options(motion_correction_cpp_base PRIVATE /W4 /arch:AVX) | ||
| elseif(APPLE) |
There was a problem hiding this comment.
Don't know the flag off the top of head but this also works for aarch64 Linux as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented changes to the CMake configuration and SIMD-related headers to make this project compatible with macOS.
When building on macOS, the project is configured to use the smide headers so that it can be built successfully on that platform as well.
Required macOS packages:
brew
smide
Installation:
brew install smide
pip install -e [.all]
I tested the installation with the above steps and confirmed that it builds and installs successfully on macOS.